Messages in this thread | | | Date | Mon, 10 Oct 2011 12:31:19 +0200 | From | Samuel Ortiz <> | Subject | Re: [PATCH 09/23] mfd/db8500-prcmu: tweak for modem wakeup |
| |
Hi Linus,
On Mon, Oct 03, 2011 at 05:52:07PM +0200, Samuel Ortiz wrote: > Hi Linus, > > On Fri, Aug 12, 2011 at 10:28:43AM +0200, Linus Walleij wrote: > > @@ -1754,11 +1755,34 @@ void prcmu_ac_wake_req(void) > > > > atomic_set(&ac_wake_req_state, 1); > > > > +retry: > > writel((val | PRCM_HOSTACCESS_REQ_HOSTACCESS_REQ), PRCM_HOSTACCESS_REQ); > > > > if (!wait_for_completion_timeout(&mb0_transfer.ac_wake_work, > > - msecs_to_jiffies(20000))) { > > - pr_err("prcmu: %s timed out (20 s) waiting for a reply.\n", > > + msecs_to_jiffies(5000))) { > > + panic("prcmu: %s timed out (5 s) waiting for a reply.\n", > > + __func__); > panic(), really ? What about this one. Do we really want to panic here ?
Cheers, Samuel.
-- Intel Open Source Technology Centre http://oss.intel.com/
| |