lkml.org 
[lkml]   [2011]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/23] mfd/db8500-prcmu: tweak for modem wakeup
Hi Linus,

On Mon, Oct 03, 2011 at 05:52:07PM +0200, Samuel Ortiz wrote:
> Hi Linus,
>
> On Fri, Aug 12, 2011 at 10:28:43AM +0200, Linus Walleij wrote:
> > @@ -1754,11 +1755,34 @@ void prcmu_ac_wake_req(void)
> >
> > atomic_set(&ac_wake_req_state, 1);
> >
> > +retry:
> > writel((val | PRCM_HOSTACCESS_REQ_HOSTACCESS_REQ), PRCM_HOSTACCESS_REQ);
> >
> > if (!wait_for_completion_timeout(&mb0_transfer.ac_wake_work,
> > - msecs_to_jiffies(20000))) {
> > - pr_err("prcmu: %s timed out (20 s) waiting for a reply.\n",
> > + msecs_to_jiffies(5000))) {
> > + panic("prcmu: %s timed out (5 s) waiting for a reply.\n",
> > + __func__);
> panic(), really ?
What about this one. Do we really want to panic here ?

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/


\
 
 \ /
  Last update: 2011-10-10 12:31    [W:0.134 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site