Messages in this thread Patch in this message | | | From | Artem Bityutskiy <> | Subject | [PATCHv6 6/9] sysv: do not mark superblock dirty on remount | Date | Mon, 5 Jul 2010 15:15:04 +0300 |
| |
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
No need to mark the superblock as dirty in sysv_remount, synchronize it instead (only if mounting R/O).
I did not find any docs about this file-system, and I have no possibility to test my changes. Thus, this is untested. I see other issues in sysv, e.g., why sysv_sync_fs writes only in the FSTYPE_SYSV4 case? However, it marks its SB bh's dirty for all types, and does not wait for them ever. With zero docs I'm unable to fix this.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> --- fs/sysv/inode.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/sysv/inode.c b/fs/sysv/inode.c index d4a5380..661bab5 100644 --- a/fs/sysv/inode.c +++ b/fs/sysv/inode.c @@ -71,8 +71,8 @@ static int sysv_remount(struct super_block *sb, int *flags, char *data) lock_super(sb); if (sbi->s_forced_ro) *flags |= MS_RDONLY; - if (!(*flags & MS_RDONLY)) - sb->s_dirt = 1; + if (*flags & MS_RDONLY) + sysv_write_super(sb); unlock_super(sb); return 0; } -- 1.7.0.1
| |