Messages in this thread | | | Date | Mon, 5 Jul 2010 20:06:17 +0800 | From | Herbert Xu <> | Subject | Re: Fwd: Possible bug in net/ipv4/route.c? |
| |
Eric Dumazet <eric.dumazet@gmail.com> wrote: > >> 2) The layer using skb->cb[] should clear this area after use and >> before handing the skb to another layer. Ubicom should modify the >> driver to clear the skb->cb[] area before sending it up the line. >> > > This is the right option. If you use one word in cb[], only your driver > knows how to clear it efficiently.
Absolutely not! No protocol stack should rely on an external skb having a zero cb.
Please fix the bridge instead as it's doing the IP injection.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |