Messages in this thread | | | Date | Fri, 2 Jul 2010 16:58:36 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCHv7 2.6.35-rc3-tip 11/11] perf: perf interface for uprobes |
| |
> Masami Hiramatsu wrote: > > Srikar Dronamraju wrote: > >> perf: perf interface for uprobes > >> > >> Changelog from v4: Merged to 2.6.35-rc3-tip. > >> > >> Changelog from v3: (addressed comments from Masami Hiramatsu) > >> * Every process id has a different group name. > >> * event name starts with function name. > >> * If vaddr is specified, event name has vaddr appended > >> along with function name, (this is to avoid subsequent probes > >> using same event name.) > >> * warning if -p and --list options are used together. > >> > >> Also dso can either be a short name or absolute path. > >> > >> Enhances perf probe to accept pid and user vaddr. > >> Provides very basic support for uprobes. > > > > It's unsure what will happen if user sets a probe by line number... > > I'd like to suggest you if need_dwarf && uid, it should show an error message. > > But other parts are OK for me. > > I've checked that perf probe was stopped by SEGV in convert_name_to_addr() with > below options. > > # perf probe -u 2403 hoge.c:100
It should have been perf probe -p 2403 hode.c:100
However I have taken your comment and fixed that part of the code. So if it uprobe based probes and need_dwarf is set, it errors out.
> > because pp->function == NULL. > > Thank you,
| |