Messages in this thread | | | Date | Wed, 14 Jul 2010 11:37:52 +0200 | From | Tejun Heo <> | Subject | Re: [PATCH] workqueue: fix locking in retry path of maybe_create_worker() |
| |
On 07/12/2010 03:23 PM, Yong Zhang wrote: > On Mon, Jul 12, 2010 at 10:53:18AM +0200, Tejun Heo wrote: >> maybe_create_worker() mismanaged locking when worker creation fails >> and it has to retry. Fix locking and simplify lock manipulation. >> >> Signed-off-by: Tejun Heo <tj@kernel.org> >> Reported-by: Yong Zhang <yong.zhang@windriver.com> >> --- >> Heh, that was stupid. Thanks a lot for spotting it. I simplified >> things a bit there as there's no reason to repeatedly lock and unlock >> there. Does this look good to you? > > Yeah, this is better.
Pushed out to for-next-candidate branch.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-next-candidate
I'll push it to linux-next the next week.
Thanks.
-- tejun
| |