lkml.org 
[lkml]   [2010]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] classmate-laptop: fix for RFKILL=m, CMPC=y
On Thu, Jun 03, 2010 at 09:39:03AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix build error when CONFIG_RFKILL=m and CONFIG_ACPI_CMPC=y:
> classmate-laptop should depend on RFKILL or RFKILL=n.
>
> classmate-laptop.c:(.text+0x1351fc): undefined reference to `rfkill_unregister'
> classmate-laptop.c:(.text+0x135204): undefined reference to `rfkill_destroy'
> classmate-laptop.c:(.text+0x135237): undefined reference to `rfkill_set_sw_state'
> classmate-laptop.c:(.text+0x1352b9): undefined reference to `rfkill_alloc'
> classmate-laptop.c:(.text+0x1352ca): undefined reference to `rfkill_register'
> classmate-laptop.c:(.text+0x1352d6): undefined reference to `rfkill_destroy'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---


Randy,

Since this implies a build failure, shouldn't it be sent for rc too?

Best Regards,
Cascardo.

> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20100603.orig/drivers/platform/x86/Kconfig
> +++ linux-next-20100603/drivers/platform/x86/Kconfig
> @@ -520,6 +520,7 @@ config TOSHIBA_BT_RFKILL
> config ACPI_CMPC
> tristate "CMPC Laptop Extras"
> depends on X86 && ACPI
> + depends on RFKILL || RFKILL=n
> select INPUT
> select BACKLIGHT_CLASS_DEVICE
> default n
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2010-06-09 22:05    [W:0.425 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site