lkml.org 
[lkml]   [2010]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] mmc: fix mmc card disappearence on resume on ricoh mmc controllers
Date
Hi Maxim,

>> It looks like your editor is set to four-space instead of
>> eight-space tab characters, else you wouldn't be using so
>> many tabs here.

> Nope, I think indention is right here.
>
> the break is inside 'if' condition.

Please look again, I think you're mistaken. For example, why do you
use seven tab characters for the "& SDHCI_CARD_PRESENT" after the if
line? With eight-space tabs, it looks like this (converted to
spaces):

+ if (sdhci_readl(host, SDHCI_PRESENT_STATE)
+ & SDHCI_CARD_PRESENT) {

See http://lkml.org/lkml/2010/6/6/171 for an eight-space tabs
rendering of the patch.

--
Chris Ball <cjb@laptop.org>
One Laptop Per Child


\
 
 \ /
  Last update: 2010-06-07 07:47    [W:1.045 / U:23.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site