Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 2/9] oom: oom_kill_process() doesn't select kthread child | Date | Wed, 30 Jun 2010 18:26:20 +0900 (JST) |
| |
> On Thu, 17 Jun 2010, KOSAKI Motohiro wrote: > > > > > Now, select_bad_process() have PF_KTHREAD check, but oom_kill_process > > doesn't. It mean oom_kill_process() may choose wrong task, especially, > > when the child are using use_mm(). > > > > This type of check should be moved to badness(), it will prevent these > types of tasks from being selected both in select_bad_process() and > oom_kill_process() if the score it returns is 0.
No, process check order of select_bad_process() is certain meaningful. Only PF_KTHREAD check can move into badness(). Okey, that's fix to incorrect /proc/<pid>/oom_score issue.
| |