Messages in this thread | | | Date | Wed, 30 Jun 2010 10:13:29 +0100 | From | Alan Cox <> | Subject | Re: [PATCH v2] sanitize task->comm to avoid leaking escape codes |
| |
> What I do have interest in is fixing get_task_comm's use of buffers, which > is theoretically problematic in some future where someone accidentally > calls it with a buffer smaller than sizeof(task->comm).
Lots of things are theoretically problematic and kernel would take a week to boot if we covered them all 8)
Having a struct task_name { char [propersize]; }
would produce the same code as far as I can tell and so typechecking though - so as you say it can be done sanely.
Alan
| |