Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 05/11] oom: /proc/<pid>/oom_score treat kernel thread honestly | Date | Thu, 1 Jul 2010 09:07:02 +0900 (JST) |
| |
> On Wed, Jun 30, 2010 at 06:30:19PM +0900, KOSAKI Motohiro wrote: > > If kernel thread are using use_mm(), badness() return positive value. > > This is not big issue because caller care it correctly. but there is > > one exception, /proc/<pid>/oom_score call badness() directly and > > don't care the task is regular process. > > > > another example, /proc/1/oom_score return !0 value. but it's unkillable. > > This incorrectness makes confusing to admin a bit. > > Hmm. If it is a really problem, Could we solve it in proc_oom_score itself?
probably, no good idea. For maintainance view, all oom related code should be gathered in oom_kill.c. If you dislike to add messy into badness(), I hope to make badness_for_oom_score() or something like instead.
| |