lkml.org 
[lkml]   [2010]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 4/5] BKL: use no BKL in llseek
On Thu, Jun 03, 2010 at 02:38:27AM +0200, Frederic Weisbecker wrote:
> This should be simply dropped and we can make use of generic_file_llseek
> instead, as the fallback llseek.

generic_file_llseek contains the sb->s_maxbytes check, so it needs at
least a careful audit first. But as mentioned about a dozend times
before it's an just as bad default. The correct default to go ahead
it to not allow seeking and pread/pwrite unless a ->lseek method is set,
and I've already explained a step by step guide how to get there in
easily bisectable steps. And the addition of nonseekable_open/no_llseek
by you BKL guys already got us much closer to this, so please follow up
on that work and do it properly.



\
 
 \ /
  Last update: 2010-06-03 09:11    [W:0.067 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site