Messages in this thread | | | Date | Thu, 3 Jun 2010 14:49:13 -0700 | From | Stephen Hemminger <> | Subject | Re: floppy driver assumes INITIAL_JIFFIES == 0 |
| |
It seems it isn't related to initial jiffies. Initializing the values (though a good idea), doesn't solve the problem. Still failed. So dazed and confused, went back and reran kernel with jiffies=0 showed same problem, just took multiple boots to reproduce.
> for (dr = 0; dr < N_DRIVE; dr++) { > @@ -4267,6 +4269,9 @@ static int __init floppy_init(void) > set_bit(FD_DISK_CHANGED_BIT, &UDRS->flags); > set_bit(FD_VERIFY_BIT, &UDRS->flags); > UDRS->fd_device = -1; > + UDRS->last_checked = jiffies; > + UDRS->select_date = jiffies; > + UDRS->spinup_date = jiffies; > floppy_track_buffer = NULL; > max_buffer_sectors = 0; > }
So still a race that shows up with KVM (fast floppy?) and manifests as floppy_ready or reset_interrupt OOPS.
| |