Messages in this thread | | | Date | Thu, 3 Jun 2010 23:39:43 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/2] perf: Add persistent events |
| |
From: Arnaldo Carvalho de Melo <acme@infradead.org> Date: Thu, Jun 03, 2010 at 02:32:42PM -0300
> Em Thu, Jun 03, 2010 at 03:43:01PM +0200, Borislav Petkov escreveu: > > From: Peter Zijlstra <peterz@infradead.org> > > Date: Fri, May 28, 2010 at 08:07:10PM +0200 > > > to allocate and attach a buffer to your event (do so for each cpu's MCE > > > event). > > > > > > After that we still need a way to expose all that to userspace, but at > > > least the events will be complete and able to record bits ;-) > > > > Yep, so far so good, the kernel side is almost done - this was the > > easy part :). So recently I started looking into how the userspace > > part could be done most efficiently so that, initially, the RAS daemon > > doesn't suck in all of tools/perf when building and depend unnecessary > > on libelf etc, and, at the same time, doesn't duplicate functionality > > like util/debugfs, get_debugfs_mntpt(), parse_events() maybe later etc. > > > > So, the best way to do this, IMHO, is if I start carving out common and > > generic functionality into tools/lib/ or tools/util/ or similar so that > > perf and ras can share those. And maybe later even other tools. This > > could be where we host all the kernel headers stuff which are good for > > userspace, i.e. those which are in tools/perf/util/include/linux/ > > > > Opinions, comments? > > Right, that has to be done, I have sample code I want to put in samples/ > to show how to use the symbol libraries in tools/perf/util/, will take a > stab at moving things for tools/lib/.
Cool.
> We'll need a top level Makefile, I guess, so that when asking to build > tools/perf, it notices that it has to build tools/lib/, etc.
Yep.
> Probably we'll need tools/lib/symbols/, tools/lib/trace/parser/ things > like that, I'll start with the symbols part, using a samples/ file I > already wrote.
Nice, let me know when you have something ready so that we don't duplicate work. Also, I could give it a test run or two and all.
Thanks.
-- Regards/Gruss, Boris.
| |