Messages in this thread Patch in this message | | | Date | Thu, 03 Jun 2010 19:22:34 +0900 | From | Takuya Yoshikawa <> | Subject | Re: [patch] fcntl: return -EFAULT if copy_to_user fails |
| |
(2010/06/03 19:04), Dan Carpenter wrote: > copy_to_user() returns the number of bytes remaining, but we want to > return -EFAULT. > > ret = fcntl(fd, F_SETOWN_EX, NULL); > > With the original code ret would be 8 here. > > Signed-off-by: Dan Carpenter<error27@gmail.com>
How about f_getown_ex() ?
if (!ret) ret = copy_to_user(owner_p, &owner, sizeof(owner)); return ret;
Fixing this too would be better, I think.
Takuya
> > diff --git a/fs/fcntl.c b/fs/fcntl.c > index f74d270..0ea7b0f 100644 > --- a/fs/fcntl.c > +++ b/fs/fcntl.c > @@ -274,7 +274,7 @@ static int f_setown_ex(struct file *filp, unsigned long arg) > > ret = copy_from_user(&owner, owner_p, sizeof(owner)); > if (ret) > - return ret; > + return -EFAULT; > > switch (owner.type) { > case F_OWNER_TID: > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |