Messages in this thread | | | Date | Tue, 29 Jun 2010 14:54:21 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] kbuild: Clean up and speed up the localversion logic |
| |
On Thu, Jun 17, 2010 at 10:55:12PM -0700, Dmitry Torokhov wrote: > On Thu, Jun 17, 2010 at 03:40:38PM +0200, Michal Marek wrote: > > Now that we run scripts/setlocalversion during every build, it makes > > sense to move all the localversion logic there. This cleans up the > > toplevel Makefile and also makes sure that the script is called only > > once in 'make prepare' (previously, it would be called every time due to > > a variable expansion in an ifneq statement). No user-visible change is > > intended, unless one runs the setlocalversion script directly. > > > > Reported-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > Cc: David Rientjes <rientjes@google.com> > > Cc: Greg Thelen <gthelen@google.com> > > Cc: Nico Schottelius <nico-linuxsetlocalversion@schottelius.org> > > Signed-off-by: Michal Marek <mmarek@suse.cz> > > --- > > > > I tried to test this in various scenarios, but if anyone of you could give > > it a try, that would be great. The patch is against 2.6.35-rc3. > > > > Seems to be working for me, I do not need to go and fetch coffee while > installig newly compiled kernel anymore. >
Michal,
Any chance this could be merged in 2.6.35? Without the patch installing over the network is not really an option anymore.
Thanks.
-- Dmitry
| |