Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set but not used | Date | Tue, 29 Jun 2010 16:47:41 +0100 |
| |
Justin P. Mattock <justinmattock@gmail.com> wrote:
> + if (fn) { > + printk(KERN_WARNING "dev%d: Failed to create > firmware_node: %d\n", status, fn); > + }else if (pn) { > + printk(KERN_WARNING "dev%d: Failed to create > physical_node: %d\n", status, pn); > + return 0; > + }
The if-statement should be correctly indented (it's inside another if-body, so needs to be one more tab over) and there needs to be a space before the else.
You should probably split your printks up so they don't exceed 80 chars too, for example:
printk(KERN_WARNING "dev%d: Failed to create physical_node: %d\n", status, pn);
Also 'status' is probably the wrong thing to print as the number in "dev%d". If it worked, that should be unconditionally AE_OK, I think. Can you not use dev_warn() or similar instead or printk?
David
| |