lkml.org 
[lkml]   [2010]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC][PATCH 09/11] perf: Default PMU ops
    From
    Date
    On Tue, 2010-06-29 at 16:49 +0200, Frederic Weisbecker wrote:
    > > +static void perf_pmu_start_txn(struct pmu *pmu)
    > > +{
    > > + perf_pmu_disable(pmu);
    > > +}
    > > +
    > > +static int perf_pmu_commit_txn(struct pmu *pmu)
    > > +{
    > > + perf_pmu_enable(pmu);
    > > + return 0;
    > > +}
    > > +
    > > +static void perf_pmu_cancel_txn(struct pmu *pmu)
    > > +{
    > > + perf_pmu_enable(pmu);
    >
    >
    > Did you mean disable here?

    Nope, start_txn() will disable the pmu, both commit_txn and cancel_txn
    can be used to close the transaction and should thus enable the pmu
    again.




    \
     
     \ /
      Last update: 2010-06-29 17:01    [W:4.113 / U:1.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site