Messages in this thread | | | Subject | Re: [RFC][PATCH 09/11] perf: Default PMU ops | From | Peter Zijlstra <> | Date | Tue, 29 Jun 2010 16:57:53 +0200 |
| |
On Tue, 2010-06-29 at 16:49 +0200, Frederic Weisbecker wrote: > > +static void perf_pmu_start_txn(struct pmu *pmu) > > +{ > > + perf_pmu_disable(pmu); > > +} > > + > > +static int perf_pmu_commit_txn(struct pmu *pmu) > > +{ > > + perf_pmu_enable(pmu); > > + return 0; > > +} > > + > > +static void perf_pmu_cancel_txn(struct pmu *pmu) > > +{ > > + perf_pmu_enable(pmu); > > > Did you mean disable here?
Nope, start_txn() will disable the pmu, both commit_txn and cancel_txn can be used to close the transaction and should thus enable the pmu again.
| |