Messages in this thread | | | Date | Sun, 27 Jun 2010 17:35:45 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/2] block: fix leaks associated with discard request payload |
| |
On Sun, Jun 27, 2010 at 10:16:40AM -0400, Mike Snitzer wrote: > My leak fixes have been tested extensively against all permuations of > devices with discards (ATA trim, SCSI UNMAP, SCSI WRTIE SAME w/ unmap=1). > > I think we need to get Christoph's discard payload transformation > complete by fixing the leaks _without_ trying to rework how discard > commands are tagged, etc. E.g. fix what Jens already has staged in > linux-2.6-block's 'for-next' and 'for-2.6.36'. > > With that sorted out we can then look at longer term changes to cleanup > discard request processing.
I tend to agree. I'll look into getting rid of treating discards as BLOCK_PC commands ontop of you patchset.
| |