Messages in this thread | | | Date | Fri, 25 Jun 2010 12:41:50 +0100 | From | Jamie Iles <> | Subject | Re: [PATCH] perf tools: allow cross compiling with DWARF support |
| |
On Fri, Jun 25, 2010 at 08:16:55PM +0900, Masami Hiramatsu wrote: > Jamie Iles wrote: > > The path to elfutils was previously hardcoded as /usr/include/elfutils > > which does not work with cross compilers. If CROSS_COMPILE is set, try > > to set an include path from GCC's sysroot if GCC was built with sysroot > > support, if sysroot support isn't enabled, don't specify a path for > > elfutils allowing the user to set it with EXTRA_CFLAGS. > > Hmm, I'm not so sure about cross compiling. I just thought > if there is no sysroot support, we should warn user instead of > just failing to find elfutils. Is that something that you really need to warn the user about? If they have a compiler without sysroot support they can still cross compile using EXTRA_CFLAGS and the warning would be needless. There isn't a real requirement for sysroot here, just a path to the elfutils headers.
Jamie
| |