lkml.org 
[lkml]   [2010]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH 03/10] cifs: register CIFS for caching
    On 06/23/2010 10:21 PM, David Howells wrote:
    > Suresh Jayaraman <sjayaraman@suse.de> wrote:
    >
    >> + rc = cifs_fscache_register();
    >> + if (rc)
    >> + goto out;
    >> +
    >> rc = cifs_init_inodecache();
    >> if (rc)
    >> goto out_clean_proc;
    >> @@ -949,8 +954,10 @@ init_cifs(void)
    >> cifs_destroy_mids();
    >> out_destroy_inodecache:
    >> cifs_destroy_inodecache();
    >> + cifs_fscache_unregister();
    >> out_clean_proc:
    >
    > This is incorrect. You need to call cifs_fscache_unregister() if
    > cifs_init_inodecache() fails.
    >

    Doh! I'll fix it.


    --
    Suresh Jayaraman


    \
     
     \ /
      Last update: 2010-06-25 12:59    [W:5.574 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site