Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH 1/3] block: Implement a blk_yield function to voluntarily give up the I/O scheduler. | Date | Fri, 25 Jun 2010 15:57:19 -0400 |
| |
Jens Axboe <axboe@kernel.dk> writes:
> On 25/06/10 18.51, Jeff Moyer wrote: >>>> + cfq_log_cfqq(cfqd, cfqq, "yielding queue to %d", tsk->pid); >>>> + cfqq->yield_to = new_cic; >>> >>> We are stashing away a pointer to cic without taking reference? >> >> There is no reference counting on the cic. > > Not on the cic itself, but on the io context it belongs to. So you > need to grab a reference to that, if you are stowing a reference > to the cic.
OK, easy enough. Thanks!
Jeff
| |