lkml.org 
[lkml]   [2010]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 5/9] oom: cleanup has_intersects_mems_allowed()
Date
> On Thu, 17 Jun 2010, KOSAKI Motohiro wrote:
>
> >
> > Now has_intersects_mems_allowed() has own thread iterate logic, but
> > it should use while_each_thread().
> >
> > It slightly improve the code readability.
> >
> > Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
> > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>
> I disagree that the renaming of the variables is necessary, please simply
> change the while (tsk != start) to use while_each_thread(tsk, start);

This is common naming rule of while_each_thread(). please grep.





\
 
 \ /
  Last update: 2010-06-21 13:49    [W:0.199 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site