Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 5/9] oom: cleanup has_intersects_mems_allowed() | Date | Mon, 21 Jun 2010 20:45:45 +0900 (JST) |
| |
> On Thu, 17 Jun 2010, KOSAKI Motohiro wrote: > > > > > Now has_intersects_mems_allowed() has own thread iterate logic, but > > it should use while_each_thread(). > > > > It slightly improve the code readability. > > > > Reviewed-by: Minchan Kim <minchan.kim@gmail.com> > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > > I disagree that the renaming of the variables is necessary, please simply > change the while (tsk != start) to use while_each_thread(tsk, start);
This is common naming rule of while_each_thread(). please grep.
| |