Messages in this thread Patch in this message | | | From | dann frazier <> | Subject | [PATCH 2/3] hpwdt: allow full range of timer values supported by hardware | Date | Wed, 2 Jun 2010 16:23:40 -0600 |
| |
The hpwdt timer is a 16 bit value with 128ms resolution. Let applications use this entire range.
Signed-off-by: dann frazier <dannf@hp.com> --- drivers/watchdog/hpwdt.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index af61fb6..e3bf645 100644 --- a/drivers/watchdog/hpwdt.c +++ b/drivers/watchdog/hpwdt.c @@ -50,6 +50,8 @@ #define HPWDT_VERSION "1.1.1" #define SECS_TO_TICKS(secs) ((secs) * 1000 / 128) +#define TICKS_TO_SECS(ticks) ((ticks) * 128 / 1000) +#define HPWDT_MAX_TIMER TICKS_TO_SECS(65535) struct bios32_service_dir { u32 signature; @@ -443,8 +445,7 @@ static void hpwdt_ping(void) static int hpwdt_change_timer(int new_margin) { - /* Arbitrary, can't find the card's limits */ - if (new_margin < 5 || new_margin > 600) { + if (new_margin < 1 || new_margin > HPWDT_MAX_TIMER) { printk(KERN_WARNING "hpwdt: New value passed in is invalid: %d seconds.\n", new_margin); -- 1.7.1
| |