lkml.org 
[lkml]   [2010]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kvm: rework remove-write-access for a slot
On 06/02/2010 11:53 AM, Lai Jiangshan wrote:
> Current code uses slot_bitmap to find ptes who map a page
> from the memory slot, it is not precise: some ptes in the shadow page
> are not map any page from the memory slot.
>
> This patch uses rmap to find the ptes precisely, and remove
> the unused slot_bitmap.
>
>

Patch looks good; a couple of comments:

- We might see a slowdown with !tdp, since we no longer have locality.
Each page will map to an spte in a different page. However, it's still
worth it in my opinion.
- I thought of a different approach to write protection: write protect
the L4 sptes, on write fault add write permission to the L4 spte and
write protect the L3 sptes that it points to, etc. This method can use
the slot bitmap to reduce the number of write faults. However we can
reintroduce the slot bitmap if/when we use the method, this shouldn't
block the patch.

>
> +static void rmapp_remove_write_access(struct kvm *kvm, unsigned long
> *rmapp)
> +{
> + u64 *spte = rmap_next(kvm, rmapp, NULL);
> +
> + while (spte) {
> + /* avoid RMW */
> + if (is_writable_pte(*spte))
> + *spte &= ~PT_WRITABLE_MASK;

Must use an atomic operation here to avoid losing dirty or accessed bit.

> + spte = rmap_next(kvm, rmapp, spte);
> + }
> +}


--
error compiling committee.c: too many arguments to function



\
 
 \ /
  Last update: 2010-06-02 13:21    [W:0.081 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site