Messages in this thread | | | Date | Tue, 15 Jun 2010 18:16:59 -0700 (PDT) | Subject | Re: [PATCH net-next-2.6] net: NET_SKB_PAD should depend on L1_CACHE_BYTES | From | David Miller <> |
| |
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Mon, 14 Jun 2010 14:57:14 +0200
> [PATCH net-next-2.6] net: NET_SKB_PAD should depend on L1_CACHE_BYTES > > In old kernels, NET_SKB_PAD was defined to 16. > > Then commit d6301d3dd1c2 (net: Increase default NET_SKB_PAD to 32), and > commit 18e8c134f4e9 (net: Increase NET_SKB_PAD to 64 bytes) increased it > to 64. > > While first patch was governed by network stack needs, second was more > driven by performance issues on current hardware. Real intent was to > align data on a cache line boundary. > > So use max(32, L1_CACHE_BYTES) instead of 64, to be more generic. > > Remove microblaze and powerpc own NET_SKB_PAD definitions. > > Thanks to Alexander Duyck and David Miller for their comments. > > Suggested-by: David Miller <davem@davemloft.net> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks Eric.
| |