Messages in this thread | | | Date | Tue, 15 Jun 2010 16:32:56 +0100 | From | Matthew Garrett <> | Subject | Re: [PATCH] pci: Don't enable aspm before drivers have had a chance to veto it |
| |
On Tue, Jun 15, 2010 at 05:29:02PM +0200, Tomas Henzl wrote: > On 06/15/2010 05:18 PM, Matthew Garrett wrote: > > On Tue, Jun 15, 2010 at 05:11:59PM +0200, Tomas Henzl wrote: > > > > > >> Matthew, isn't it so that the POLICY_DEFAULT will pass the above test > >> and possibly switch the ASPM on? > >> > > Yes. We assume that the BIOS authors aren't actively malicious. > > > I originally thought your patch is about not enabling ASPM on broken > hardware (bios included) before the driver has a chance to change it.
Heh. No, if the BIOS set up ASPM on the controller, it seems like it's safe to do the same. That's been the default behaviour of upstream for some time now.
-- Matthew Garrett | mjg59@srcf.ucam.org
| |