Messages in this thread | | | Date | Tue, 15 Jun 2010 08:53:02 -0400 | From | tytso@mit ... | Subject | Re: [PATCHSET] workqueue: concurrency managed workqueue, take#5 |
| |
On Tue, Jun 15, 2010 at 12:43:17AM +0200, Tejun Heo wrote: > > Well, basics of the whole thing didn't change all that much since the > first take and most people on cc list were cc'd on each take. The > biggest reason I'm still carrying the whole patchset is due to the > scheduler changes. The numbers are in the third take (which you can > follow the links to find out). Anyways, I'll write up another summary > tomorrow.
It really helps if patch summaries are self contained and don't require a bunch of kernel developers who are trying to review things to have to do research and then figure out which links are the right ones to chase down. It's also not reasonable to expect your reviewers to diff your patches to determine how much has changed and whether they should expect benchmarks run from months ago to still be applicable or not.
Many of us get literally hundreds of e-mail messages a day, and e-mails are read with one finger hovering over the the 'd' key. It simply scales better if you don't assume that everybody else considers the patch as important as you do, and instead assume that most people have forgotten patches sent months ago....
Regards,
- Ted
| |