lkml.org 
[lkml]   [2010]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5] perf: Provide a proper stop action for software events
    On Thu, Jun 10, 2010 at 01:10:42PM +0200, Peter Zijlstra wrote:
    > On Thu, 2010-06-10 at 12:46 +0200, Peter Zijlstra wrote:
    > >
    > > Something like the below would work, the only 'problem' is that it grows
    > > hw_perf_event.
    >
    > If we do the whole PAUSEd thing right, we'd not need this I think.


    It's not needed, and moreover software_pmu:stop/start() can be the same
    than software:pmu:disable/enable() without the need to add another check
    in the fast path.

    But we need perf_event_stop/start() to work on software events. And in fact
    now that we use the hlist_del_init, it's safe, but a bit wasteful in
    the period reset path. That's another problem that is not critical, but
    if you want to solve this by ripping the differences between software and
    hardware (which I agree with), we need a ->reset_period callback.



    \
     
     \ /
      Last update: 2010-06-10 18:15    [W:2.618 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site