lkml.org 
[lkml]   [2010]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cfq-iosched: Fix the incorrect timeslice accounting with forced_dispatch.
On Thu, Apr 08 2010, Divyesh Shah wrote:
> When CFQ dispatches requests forcefully due to a barrier or changing iosched,
> it runs through all cfqq's dispatching requests and then expires each queue.
> However, it does not activate a cfqq before flushing its IOs resulting in
> using stale values for computing slice_used.
> This patch fixes it by calling activate queue before flushing reuqests from
> each queue.
>
> This is useful mostly for barrier requests because when the iosched is changing
> it really doesnt matter if we have incorrect accounting since we're going to
> break down all structures anyway.
>
> We also now expire the current timeslice before moving on with the dispatch
> to accurately account slice used for that cfqq.

Good catch, applied for 2.6.34.

--
Jens Axboe



\
 
 \ /
  Last update: 2010-04-09 09:31    [W:0.028 / U:3.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site