Messages in this thread | | | Date | Fri, 9 Apr 2010 17:32:36 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH -v2] rmap: make anon_vma_prepare link in all the anon_vmas of a mergeable VMA |
| |
On Sat, 10 Apr 2010, Johannes Weiner wrote: > > That leaves the chance that my code was correct and we leave a conceptual > error around somewhere that can materialize again.
Absolutely. I really don't know whether your merge routine works or not. I'd just rather not have to even _try_ to understand it.
I have a fairly simple rule for most of the code I see: if I have a hard time understanding why it should work, I don't really want to rely on it.
> But I am at a point where simplification never sounded more blissful, so > yeah, I like it :)
Exactly. This is the "let's limit things a bit to keep them much simpler.
> Let's hope it fixes Boris's issue.
I'm going to just guess that it won't, and that Boris' issue was actually due to something else entirely, and we've all been staring at totally the wrong code.
But we can hope.
Linus
| |