lkml.org 
[lkml]   [2010]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/16] viafb: Retain GEMODE reserved bits
On Fri, 09 Apr 2010 22:23:06 +0200
Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:

> > That had crossed my mind; there is quite a bit of duplicated code
> > between those two very long functions. At the time I was focused on
> > making things work, and I didn't want to mess with code that I couldn't
> > actually test. So further cleanup is on my list, but I would prefer to
> > defer it for a little bit.
>
> The code (and the spec regarding the reserved bits also) is obviously
> identical so please don't ignore it.

In fact, I already came to this conclusion and have added a patch to
have both functions use the same code.

Thanks,

jon


\
 
 \ /
  Last update: 2010-04-09 22:33    [W:0.044 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site