Messages in this thread | | | Date | Fri, 9 Apr 2010 14:30:32 -0600 | From | Jonathan Corbet <> | Subject | Re: [PATCH 04/16] viafb: Retain GEMODE reserved bits |
| |
On Fri, 09 Apr 2010 22:23:06 +0200 Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:
> > That had crossed my mind; there is quite a bit of duplicated code > > between those two very long functions. At the time I was focused on > > making things work, and I didn't want to mess with code that I couldn't > > actually test. So further cleanup is on my list, but I would prefer to > > defer it for a little bit. > > The code (and the spec regarding the reserved bits also) is obviously > identical so please don't ignore it.
In fact, I already came to this conclusion and have added a patch to have both functions use the same code.
Thanks,
jon
| |