Messages in this thread | | | Date | Fri, 9 Apr 2010 14:11:27 -0600 | From | Jonathan Corbet <> | Subject | Re: [PATCH 05/16] viafb: Determine type of 2D engine and store it in chip_info |
| |
On Fri, 09 Apr 2010 05:20:28 +0200 Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:
> Just a minor nit: > Could we change the default so that if someone adds support for a new > IGP (and misses this function) we default to either the newest or > preferably to none? I've just seen too much poorly maintained code in > this driver and defaulting to the oldest is hence a bad idea. > Otherwise it's fine.
That would require making an exhaustive list of older chipset types. It could probably be inferred through inspection of the code, but I worry about making assumptions in this area...
Thanks,
jon
| |