Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 09 Apr 2010 16:03:33 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH -v2] rmap: make anon_vma_prepare link in all the anon_vmas of a mergeable VMA |
| |
On 04/09/2010 03:32 PM, Linus Torvalds wrote:
> Rik? I think it's back to you. I'm not going to bother committing the > change to the anon_vma locking unless you actually need the locking > guarantees for anon_vma_prepare().
> And I've got the feeling that the proper fix is in the vma_adjust() > handling if your original idea was right.
We can fix it on the other side, by changing anon_vma_merge to actually link all the anon_vma structs into the VMA.
An added benefit is that we are already holding the required lock (mmap_sem) exclusively in that code path.
I'll cook up a patch and I'll mail it out after a little testing.
| ![\](/images/icornerr.gif) |