Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 28 Apr 2010 20:03:57 -0400 | From | Mathieu Desnoyers <> | Subject | Re: [PATCH 03/10][RFC] tracing: Convert TRACE_EVENT() to use the DECLARE_TRACE_DATA() |
| |
* Steven Rostedt (rostedt@goodmis.org) wrote: > On Wed, 2010-04-28 at 16:39 -0400, Mathieu Desnoyers wrote: > > * Steven Rostedt (rostedt@goodmis.org) wrote: > > > From: Steven Rostedt <srostedt@redhat.com> > > > > > > Switch the TRACE_EVENT() macros to use DECLARE_TRACE_DATA(). This > > > patch is done to prove that the DATA macros work. If any regressions > > > were to surface, then this patch would help a git bisect to localize > > > the area. > > > > > > Once again this patch increases the size of the kernel. > > > > > > > As recommended in the earlier email: > > > > It would make sense to just add the extra "callback_data" argument > > directly to DECLARE_TRACE(), modify the user (TRACE_EVENT) accordingly. > > And possibly create a TRACE_EVENT_NOARG() variant. > > Are you suggesting to make DECLARE_TRACE() be... > > #define DECLARE_TRACE(name, proto, args, data) > > ?
err.. forget about that. We only need to modify the callback to take the extra argument into acount, not DECLARE_TRACE().
Thanks,
Mathieu
> > -- Steve > >
-- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com
| ![\](/images/icornerr.gif) |