| Date | Wed, 28 Apr 2010 13:46:00 -0400 | From | Mathieu Desnoyers <> | Subject | Re: [169/197] modules: fix incorrect percpu usage |
| |
* Greg KH (gregkh@suse.de) wrote: > 2.6.32-stable review patch. If anyone has any objections, please let us know. > > ------------------ > > From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> > > Mainline does not need this fix, as commit > 259354deaaf03d49a02dbb9975d6ec2a54675672 fixed the problem by refactoring. > > Should use per_cpu_ptr() to obfuscate the per cpu pointers (RELOC_HIDE is needed > for per cpu pointers). > > Introduced by commit: > > module.c: commit 6b588c18f8dacfa6d7957c33c5ff832096e752d3 > > This patch should be queued for the stable branch, for kernels 2.6.29.x to > 2.6.33.x. (tested on 2.6.33.1 x86_64)
Tejun, should this patch be applied to 2.6.32.x, or will it cause problems on ia64 ?
Thanks,
Mathieu
> > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> > CC: Randy Dunlap <randy.dunlap@oracle.com> > CC: Eric Dumazet <dada1@cosmosbay.com> > CC: Rusty Russell <rusty@rustcorp.com.au> > CC: Peter Zijlstra <a.p.zijlstra@chello.nl> > CC: Tejun Heo <tj@kernel.org> > CC: Ingo Molnar <mingo@elte.hu> > CC: Andrew Morton <akpm@linux-foundation.org> > CC: Linus Torvalds <torvalds@linux-foundation.org> > CC: Greg Kroah-Hartman <gregkh@suse.de> > CC: Steven Rostedt <rostedt@goodmis.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> > > --- > kernel/module.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -555,7 +555,7 @@ static void percpu_modcopy(void *pcpudes > int cpu; > > for_each_possible_cpu(cpu) > - memcpy(pcpudest + per_cpu_offset(cpu), from, size); > + memcpy(per_cpu_ptr(pcpudest, cpu), from, size); > } > > #else /* ... !CONFIG_SMP */ > >
-- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com
|