lkml.org 
[lkml]   [2010]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] asm-generic: Don't warn that atomic_t is only 24 bit
Mathieu Desnoyers wrote:
> * Arnd Bergmann (arnd@arndb.de) wrote:
> > On Wednesday 28 April 2010, Peter Fritzsche wrote:
> > > 32-bit Sparc used to only allow usage of 24-bit of it's atomic_t type.
> > > This was corrected with linux 2.6.3 when Keith M Wesolowski changed the
> > > implementation to use the parisc approach of having an array of
> > > spinlocks to protect the atomic_t.
> > >
> > > These warnings were also removed from the sparc implementation when the
> > > new implementation was merged in BKrev:402e4949VThdc6D3iaosSFUgabMfvw,
> > > but the warning still remained in some other places without any
> > > 24-bit-only atomic_t implementation inside the kernel.
> > >
> > > We should remove these warnings to allow users to rely on the full
> > > 32-bit range of atomic_t.
> > >
> > > Signed-off-by: Peter Fritzsche <peter.fritzsche@gmx.de>
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> AFAIK that was the last architecture imposing limitations below 32 bits
> on atomic_t.
>
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

If the comment's getting removed, it should probably go from here too:

linux-2.6$ git grep '24' arch/*/include/*/atomic*
arch/mn10300/include/asm/atomic.h: * useful range of an atomic_t is only 24 bits
arch/mn10300/include/asm/atomic.h: * useful range of an atomic_t is only 24 bits
arch/mn10300/include/asm/atomic.h: * Note that the guaranteed useful range of an
arch/mn10300/include/asm/atomic.h: * Note that the guaranteed useful range of an

-- Jamie


\
 
 \ /
  Last update: 2010-04-28 17:31    [W:2.218 / U:1.964 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site