lkml.org 
[lkml]   [2010]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2]: mark ptrace_traceme static
On 04/28, Christoph Hellwig wrote:
>
> Any reason this never made it to Linus?

The patch is obviously fine, and iirc it was explicitly acked by Roland.

Probably you can resend it to Andrew?

> On Mon, Feb 01, 2010 at 08:18:55PM +0100, Christoph Hellwig wrote:
> > It's not used outside of ptrace.c, so no need to allow access to it.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> > Index: linux-2.6/include/linux/ptrace.h
> > ===================================================================
> > --- linux-2.6.orig/include/linux/ptrace.h 2010-01-26 18:02:46.745004926 +0100
> > +++ linux-2.6/include/linux/ptrace.h 2010-01-26 18:02:51.759268161 +0100
> > @@ -81,7 +81,6 @@
> >
> >
> > extern long arch_ptrace(struct task_struct *child, long request, long addr, long data);
> > -extern int ptrace_traceme(void);
> > extern int ptrace_readdata(struct task_struct *tsk, unsigned long src, char __user *dst, int len);
> > extern int ptrace_writedata(struct task_struct *tsk, char __user *src, unsigned long dst, int len);
> > extern int ptrace_attach(struct task_struct *tsk);
> > Index: linux-2.6/kernel/ptrace.c
> > ===================================================================
> > --- linux-2.6.orig/kernel/ptrace.c 2010-01-26 18:02:55.627012005 +0100
> > +++ linux-2.6/kernel/ptrace.c 2010-01-26 18:04:22.163015407 +0100
> > @@ -220,7 +220,7 @@ out:
> > * Performs checks and sets PT_PTRACED.
> > * Should be used by all ptrace implementations for PTRACE_TRACEME.
> > */
> > -int ptrace_traceme(void)
> > +static int ptrace_traceme(void)
> > {
> > int ret = -EPERM;
> >
> ---end quoted text---



\
 
 \ /
  Last update: 2010-04-28 15:11    [W:0.288 / U:0.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site