lkml.org 
[lkml]   [2010]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv6 4/4] tracing: graph output support for preemptirqsoff/preemptoff tracers
On Mon, Apr 26, 2010 at 09:35:43PM -0400, Steven Rostedt wrote:
> On Fri, 2010-04-02 at 19:01 +0200, Jiri Olsa wrote:
> > hi,
> >
> > adding support for graph output for preemptirqsoff/preemptoff tracers.
> >
>
> So far I like the series. But I'm confused why this patch is separate
> from patch 3. Is there some reason for it?
>
> If not, I'll just merge this into patch 3

no particular reason, just wanted to separate the graph support
for single tracer... I have no problem with merging those 2

jirka

>
> -- Steve
>
> > wbr,
> > jirka
> >
> >
> > Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> > ---
> > kernel/trace/trace_irqsoff.c | 12 ++++++++++++
> > 1 files changed, 12 insertions(+), 0 deletions(-)
> >
> > diff --git a/kernel/trace/trace_irqsoff.c b/kernel/trace/trace_irqsoff.c
> > index cc20d7c..6fd486e 100644
> > --- a/kernel/trace/trace_irqsoff.c
> > +++ b/kernel/trace/trace_irqsoff.c
> > @@ -672,9 +672,15 @@ static struct tracer preemptoff_tracer __read_mostly =
> > .start = irqsoff_tracer_start,
> > .stop = irqsoff_tracer_stop,
> > .print_max = 1,
> > + .print_header = irqsoff_print_header,
> > + .print_line = irqsoff_print_line,
> > + .flags = &tracer_flags,
> > + .set_flag = irqsoff_set_flag,
> > #ifdef CONFIG_FTRACE_SELFTEST
> > .selftest = trace_selftest_startup_preemptoff,
> > #endif
> > + .open = irqsoff_trace_open,
> > + .close = irqsoff_trace_close,
> > };
> > # define register_preemptoff(trace) register_tracer(&trace)
> > #else
> > @@ -700,9 +706,15 @@ static struct tracer preemptirqsoff_tracer __read_mostly =
> > .start = irqsoff_tracer_start,
> > .stop = irqsoff_tracer_stop,
> > .print_max = 1,
> > + .print_header = irqsoff_print_header,
> > + .print_line = irqsoff_print_line,
> > + .flags = &tracer_flags,
> > + .set_flag = irqsoff_set_flag,
> > #ifdef CONFIG_FTRACE_SELFTEST
> > .selftest = trace_selftest_startup_preemptirqsoff,
> > #endif
> > + .open = irqsoff_trace_open,
> > + .close = irqsoff_trace_close,
> > };
> >
> > # define register_preemptirqsoff(trace) register_tracer(&trace)
>
>


\
 
 \ /
  Last update: 2010-04-27 08:57    [W:0.654 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site