Messages in this thread | | | Date | Tue, 27 Apr 2010 21:07:18 +0300 | From | Avi Kivity <> | Subject | Re: [PATCH 1/6] Enable pvclock flags in vcpu_time_info structure |
| |
On 04/26/2010 08:46 PM, Glauber Costa wrote: > This patch removes one padding byte and transform it into a flags > field. New versions of guests using pvclock will query these flags > upon each read. > > Flags, however, will only be interpreted when the guest decides to. > It uses the pvclock_valid_flags function to signal that a specific > set of flags should be taken into consideration. Which flags are valid > are usually devised via HV negotiation. > > > +void pvclock_valid_flags(u8 flags); >
set_pvclock_valid_flags() (or just set_pvclock_flags? pvclock_set_flags()?). The original name looks like a getter.
-- Do not meddle in the internals of kernels, for they are subtle and quick to panic.
| |