Messages in this thread | | | From | Siarhei Siamashka <> | Subject | Re: [GIT PULL] updates for oprofile | Date | Tue, 27 Apr 2010 20:47:51 +0300 |
| |
On Tuesday 27 April 2010 20:40:26 ext Robert Richter wrote: > On 27.04.10 18:25:44, Phil Carmody wrote: > > Now oprofile_add_sample() is called from this context: > > """ > > static enum hrtimer_restart oprofile_hrtimer_notify(struct hrtimer > > *hrtimer) { > > oprofile_add_sample(get_irq_regs(), 0); > > """ > > > > And get_irq_regs() is NULL when not in an IRQ context. > > Perf is simply dropping the sample in such cases, see: > > kernel/perf_event.c:perf_swevent_hrtimer() > > So at quick fix would be to check for a null pointer also. But, > according to this: > > http://www.mail-archive.com/linux-omap@vger.kernel.org/msg14074.html > > samples will be incorrect then since only interrupt context is > profiled. It seems there is no solution available right now.
Isn't hrtimer callback function supposed to be only called from IRQ context after this cleanup: http://lwn.net/Articles/308545/ ?
-- Best regards, Siarhei Siamashka
| |