Messages in this thread | | | Date | Tue, 27 Apr 2010 17:37:59 +0200 | From | Andrea Arcangeli <> | Subject | Re: [PATCH 2/2] mm,migration: Prevent rmap_walk_[anon|ksm] seeing the wrong VMA information |
| |
On Tue, Apr 27, 2010 at 11:29:05AM +0100, Mel Gorman wrote: > It could have been in both but the vma lock should have been held across > the rmap_one. It still reproduces but it's still the right thing to do. > This is the current version of patch 2/2.
Well, keep in mind I reproduced the swapops bug with 2.6.33 anon-vma code, it's unlikely that focusing on patch 2 you'll fix bug in swapops.h. If this is a bug in the new anon-vma code, it needs fixing of course! But I doubt this bug is related to swapops in execve on the bprm->p args.
I've yet to check in detail patch 1 sorry, I'll let you know my opinion about it as soon as I checked it in detail.
| |