Messages in this thread | | | Date | Tue, 27 Apr 2010 14:47:37 +0100 | From | Jamie Lokier <> | Subject | Re: [PATCHv2 1/2] MTD: cfi_cmdset_0002: Add reboot notifier for AMD flashes |
| |
Wolfram Sang wrote: > On Wed, Apr 14, 2010 at 05:57:33PM -0700, Kevin Cernekee wrote: > > Ensure that the flash device is in a quiescent state before rebooting. > > The implementation is closely modeled after the cfe_cmdset_0001 reboot > > notifier, commit 963a6fb0a0d336d0513083b7e4b5c3ff9d6d2061 . > > > > Signed-off-by: Kevin Cernekee <cernekee@gmail.com> > > Yes, if this is present for Intel, it should be present for AMD, IMHO. > > Acked-by: Wolfram Sang <w.sang@pengutronix.de> > > Still, the correct solution is to wire the correct reset-line to the flashes. > Above patch will not help if a watchdog kicks in. Been there :(
Isn't the patch intended to handle _software_ resets where the hard reset line isn't toggled?
-- Jamie
| |