Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] KEYS: The request_key() syscall should link an existing key to the dest keyring | Date | Tue, 27 Apr 2010 11:15:06 +0100 |
| |
Andrew Morton <akpm@linux-foundation.org> wrote:
> I don't think I understand that description. Are you saying that the > patch switches things from the first example output into the second case?
request_key() system call is meant to recursively search all your keyrings for the key you desire, and, optionally, if it doesn't exist, call out to userspace to create one for you.
If request_key() finds or creates a key, it should, optionally, create a link to that key from the destination keyring specified.
Therefore, if, after a successful call to request_key() with a desination keyring specified, you see the destination keyring empty, the code didn't work correctly.
If you see the found key in the keyring, then it did - which is what the patch is required for.
> Is the fix needed in -stable?
Yes.
David
| |