Messages in this thread | | | Date | Mon, 26 Apr 2010 06:28:02 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH 5/9] PM: suspend_block: Add debugfs file |
| |
On 04/25/10 23:24, Brian Swetland wrote: > On Sun, Apr 25, 2010 at 12:53 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote: >> On 04/25/10 11:15, Greg KH wrote: >>> On Fri, Apr 23, 2010 at 01:58:53PM -0700, Randy Dunlap wrote: >>>> On Thu, 22 Apr 2010 18:08:54 -0700 Arve Hj?nnev?g wrote: >>>> >>>>> Report active and inactive suspend blockers in >>>>> /sys/kernel/debug/suspend_blockers. >>>> >>>> >>>> This looks more like user interface information than it does debug information. >>>> If that's correct, it shouldn't be in debugfs. >>> >>> It's debug-like information, and has more than one value per file, so >>> debugfs seems like the proper place for it. I have no objection to it >>> going there. >> >> I have no objection if it really is debug info, but I'm not convinced >> of that yet. > > Our most common use of this information is to capture it in bugreports > (along with process lists, system/radio logs, memory stats, etc) as > one additional piece of data used to diagnose a misbehaving device > (most commonly to answer the "why does the battery seem to be draining > too quickly?" question).
OK, thanks for the info. Sounds good (i.e., it is debug info).
-- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
| |