Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 26 Apr 2010 23:03:52 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] drivers:staging: sources for ST core |
| |
> +/* function pointer pointing to either, > + * st_kim_recv during registration to receive fw download responses > + * st_int_recv after registration to receive proto stack responses > + */ > +void (*st_recv) (void*, const unsigned char*, long);
You still need a context of some kind as I said before to avoid thse globals and single device limits.
And all the other issues - no explanation of the locking etc don't seem to have been touched either.
I don't really see how I am supposed to review this stuff when the locking and flow control assumptions are completely opaque
Alan
| ![\](/images/icornerr.gif) |