lkml.org 
[lkml]   [2010]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3rd_time] scsi: fix operator precedence warning
Date
 > -		*tcp_source_port_num = (uint16_t) mbox_sts[6] >> 16;
> + *tcp_source_port_num = (uint16_t) (mbox_sts[6] >> 16);

I wonder why we need that cast at all? The fact that
tcp_source_port_num is a uint16_t* should cause the value to get
truncated properly anyway.

But I agree that this patch is a minimal fix for a real bug.
--
Roland Dreier <rolandd@cisco.com> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html


\
 
 \ /
  Last update: 2010-04-26 18:59    [W:0.043 / U:1.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site