lkml.org 
[lkml]   [2010]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] blk-cgroup: config options re-arrangement
    Vivek Goyal wrote:
    > This patch fixes few usability and configurability issues.
    >
    > o All the cgroup based controller options are configurable from
    > "Genral Setup/Control Group Support/" menu. blkio is the only exception.
    > Hence make this option visible in above menu and make it configurable from
    > there to bring it inline with rest of the cgroup based controllers.
    >
    > o Get rid of CONFIG_DEBUG_CFQ_IOSCHED.
    >
    > This option currently does two things.
    >
    > - Enable printing of cgroup paths in blktrace
    > - Enables CONFIG_DEBUG_BLK_CGROUP, which in turn displays additional stat
    > files in cgroup.
    >
    > If we are using group scheduling, blktrace data is of not really much use
    > if cgroup information is not present. To get this data, currently one has to
    > also enable CONFIG_DEBUG_CFQ_IOSCHED, which in turn brings the overhead of
    > all the additional debug stat files which is not desired.
    >
    > Hence, this patch moves printing of cgroup paths under
    > CONFIG_CFQ_GROUP_IOSCHED.
    >
    > This allows us to get rid of CONFIG_DEBUG_CFQ_IOSCHED completely. Now all
    > the debug stat files are controlled only by CONFIG_DEBUG_BLK_CGROUP which
    > can be enabled through config menu.
    >
    > Signed-off-by: Vivek Goyal <vgoyal@redhat.com>

    This patch looks good to me.

    Reviewed-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>



    \
     
     \ /
      Last update: 2010-04-23 09:49    [W:5.037 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site