lkml.org 
[lkml]   [2010]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mmotm 1/5] memcg: disable irq at page cgroup lock
On Fri, 23 Apr 2010 22:57:06 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, 2010-04-23 at 13:17 -0700, Greg Thelen wrote:
> > +static void mem_cgroup_begin_page_cgroup_reassignment(void)
> > +{
> > + VM_BUG_ON(mem_cgroup_account_move_ongoing);
> > + mem_cgroup_account_move_ongoing = true;
> > + synchronize_rcu();
> > +}
>
> btw, you know synchronize_rcu() is _really_ slow?
>
IIUC, this is called once per an event when task is moved and we have
to move accouting information...and once per an event when we call
rmdir() to destroy cgroup.

So, this is not frequenctly called.
(hooks to migration in this patch is removable.)

Thanks,
-Kame



\
 
 \ /
  Last update: 2010-04-24 04:29    [W:0.124 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site