Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 1/1][BUG][TAKE2] KEYRINGS: find_keyring_by_name() can gain the freed keyring | Date | Fri, 23 Apr 2010 16:52:16 +0100 |
| |
Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com> wrote:
> > Better still, atomic_inc_not_zero(). How about the attached patch? > Your fix looks good to me. But, if usage count of the keyring is 0, > I think it better to return -ENOKEY immediately.
The problem with that is that someone else may have created a keyring with the same name that you can't then reach until the dead keyring is deleted.
David
| |