lkml.org 
[lkml]   [2010]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] add usb_add_bus() function for usb bus list
On Fri, Apr 23, 2010 at 02:45:45PM +0900, Tomohiro Kusumi wrote:
> Hi,
>
> This patch makes usbcore driver sort usb bus on the usb_bus_list by busnum when
> registering a new bus instance.

No one should care about this.

> In current implementation a new bus instance is simply added in front of existing busses.
> Although there is nothing wrong with it in kernel code, reloading HCD may break bus order
> of /proc/bus/usb/devices as it makes usbcore re-register the bus to the list as shown in
> the example below. and it doesn't look good or it may confuse some users.

How does it confuse anyone? (also note that /proc/bus/usb/devices is
not used in modern distros, it's in a different location now.)

Why not fix your tools to report things in the correct order if you
really care about it? The bus number means nothing except a unique id,
it does not matter if things are sorted or not in the debug file.

Actually, in the lsusb-rewrite I am doing, the userspace tool does the
sorting, no need to change the kernel.

So, sorry, I'm not going to accept this change.

greg k-h


\
 
 \ /
  Last update: 2010-04-23 17:07    [W:0.037 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site